Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed an oopsie where keybindings UI doesn't process the + key #72985

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fixed an oopsie where keybindings UI doesn't process the + key #72985

merged 1 commit into from
Apr 15, 2024

Conversation

katemonster33
Copy link
Contributor

Summary

Bugfixes "Fixed issue where the keybindings UI doesn't let you press the plus key to add a local keybinding"

Purpose of change

Fixes: #72980

Describe the solution

Totally just some test code that I had that got into master, I was trying to figure out why the keybindings UI couldn't process the keys with the normal action ID handling. I didn't figure it out and I guess I forgot to revert it all.

Describe alternatives you've considered

Testing

open the keybindings UI, press the plus key, verify it now works as it should.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 12, 2024
@Maleclypse Maleclypse merged commit d2718cc into CleverRaven:master Apr 15, 2024
23 of 28 checks passed
SurFlurer added a commit to SurFlurer/Cataclysm-DDA that referenced this pull request Aug 26, 2024
@SurFlurer
Revert "Merge pull request CleverRaven#72985 from katemonster33/imgui…
3abe441 
…_keybindings_plus_key"

This reverts commit d2718cc, reversing
changes made to 316fd4b.

this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImGui. Keybindings. Doesn't work."Add local keybinding."
2 participants
@katemonster33 @Maleclypse